Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added group filtering feature to strace #1412

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

salsal97
Copy link
Contributor

This PR adds group filtering to the strace filter options. The groups available are {"desc", "file", "ipc", "network", "process", "signal", "memory", "stat", "lstat", "fstat", "stat_like", "statfs", "fstatfs", "statfs_like", "pure", "syscall_never_fails", "max_args", "memory_mapping_change", "stackcapture_on_enter", "compat_syscall_types", "seccomp_default", "creds", "clock", "comm_change"}.

The table specifying the syscall groups mimics the strace source, a combination of these two files - https://gitlab.com/strace/strace/-/blob/master/src/linux/x86_64/syscallent.h & https://gitlab.com/strace/strace/-/blob/master/src/sysent_shorthand_defs.h

Copy link
Collaborator

@anakrish anakrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a high-level, looks good to me.

include/myst/syscall.h Outdated Show resolved Hide resolved
utils/syscall.c Outdated Show resolved Hide resolved
tools/myst/host/strace.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@vtikoo vtikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Excited to try this out.

doc/user-getting-started.md Outdated Show resolved Hide resolved
doc/user-getting-started.md Outdated Show resolved Hide resolved
utils/syscall.c Outdated Show resolved Hide resolved
utils/syscall.c Outdated Show resolved Hide resolved
utils/syscall.c Show resolved Hide resolved
utils/syscall.c Outdated Show resolved Hide resolved
utils/syscall.c Show resolved Hide resolved
utils/syscall.c Show resolved Hide resolved
utils/syscall.c Outdated Show resolved Hide resolved
Copy link
Collaborator

@asvrada asvrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments

added strace tests

docs updated

man strace details added
@salsal97 salsal97 merged commit 0fbb661 into deislabs:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants