Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smaller mutex scope + use new SDK android methods (Defold 1.2.188) #31

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Smaller mutex scope + use new SDK android methods (Defold 1.2.188) #31

merged 1 commit into from
Oct 31, 2021

Conversation

AGulev
Copy link
Contributor

@AGulev AGulev commented Oct 31, 2021

  • Use smaller scope for the callback's mutex to avoid possible ANRs/Crashes
  • Use new Defold SDK API (1.2.188) for attaching VM thread and loading java class

@AGulev AGulev requested a review from britzl October 31, 2021 13:09
britzl
britzl approved these changes Oct 31, 2021
View reviewed changes
Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AGulev AGulev merged commit d064ab0 into master Oct 31, 2021
@AGulev AGulev deleted the fix/mutex-scope branch October 31, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britzl britzl britzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AGulev @britzl