chore: lint #21
Closed
chore: lint #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjnagel
previously approved these changes
Feb 5, 2024
zachariahmiller
requested changes
Feb 5, 2024
Racer159
reviewed
Feb 12, 2024
Comment on lines
+61
to
+68
| { | ||
| "fileMatch": [".*\\.ya?ml$"], | ||
| "matchStrings": [ | ||
| "# renovate: repo-file depName=(?<depName>.*?)( versioning=(?<versioning>.*?))?\\n.*\\/(?<currentValue>v.*?)\\/" | ||
| ], | ||
| "versioningTemplate": "{{#if versioning}}{{{versioning}}}{{else}}semver-coerced{{/if}}", | ||
| "datasourceTemplate": "github-tags" | ||
| }, |
There was a problem hiding this comment.
I would recommend we don't do this. This is going to be very messy long term and instead we should pick a single renovate comment format.
There was a problem hiding this comment.
As of #20 this repo now uses this renovate configuration: https://github.com/defenseunicorns/uds-common/blob/main/config/renovate.json5
This common rule will match this dependency without needing a # renovate comment at all: https://github.com/defenseunicorns/uds-common/blob/main/config/renovate.json5#L30
There was a problem hiding this comment.
|
closing as completed in #41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lint project and update pre-commit