-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: lint #21
chore: lint #21
Conversation
{ | ||
"fileMatch": [".*\\.ya?ml$"], | ||
"matchStrings": [ | ||
"# renovate: repo-file depName=(?<depName>.*?)( versioning=(?<versioning>.*?))?\\n.*\\/(?<currentValue>v.*?)\\/" | ||
], | ||
"versioningTemplate": "{{#if versioning}}{{{versioning}}}{{else}}semver-coerced{{/if}}", | ||
"datasourceTemplate": "github-tags" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend we don't do this. This is going to be very messy long term and instead we should pick a single renovate comment format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of #20 this repo now uses this renovate configuration: https://github.com/defenseunicorns/uds-common/blob/main/config/renovate.json5
This common rule will match this dependency without needing a # renovate
comment at all: https://github.com/defenseunicorns/uds-common/blob/main/config/renovate.json5#L30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closing as completed in #41 |
lint project and update pre-commit