Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing of release artifacts before publish on release workflow #84

Closed
Tracked by #30
ericwyles opened this issue Jun 3, 2024 · 0 comments · Fixed by #91
Closed
Tracked by #30

Add testing of release artifacts before publish on release workflow #84

ericwyles opened this issue Jun 3, 2024 · 0 comments · Fixed by #91
Assignees

Comments

@ericwyles
Copy link
Contributor

Currently, we test artifacts before creating a release and then upon creating a release we build them again and then publish without testing. This can cause an issue where we could pull in (for example) a bad, updated registry1 image and we cant have absolute confidence the published artifact works. This issue will be to update the flow on release as follows:

Create Release -> build packages supporting the release -> test the built packages by deploying them -> on successful deploy, publish the artifacts to OCI.

Relates to: defenseunicorns/uds-software-factory#30

@ericwyles ericwyles self-assigned this Jun 3, 2024
@ericwyles ericwyles changed the title Add testing of release artifacts before publish on release workflows Add testing of release artifacts before publish on release workflow Jun 3, 2024
ericwyles added a commit that referenced this issue Jun 17, 2024
## Description

Add arm64 architecture and qemu for running the tests. This allows us to
test and publish arm64 packages even if they still need to contain some
amd64 images.

## Related Issue

Relates to #84 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-mattermost/blob/main/CONTRIBUTING.md#developer-workflow)
followed
ericwyles added a commit that referenced this issue Jun 18, 2024
## Description

After doing some more experiments we decided to not run arm64 tests
under emulation. We will still build the package but not run tests on
it. This PR splits the publish steps up into build/test/publish so that
they can be selectively ran based on architecture, skipping the tests on
arm64.

## Related Issue

Relates to #84 

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-mattermost/blob/main/CONTRIBUTING.md#developer-workflow)
followed
ericwyles added a commit that referenced this issue Jun 20, 2024
## Description
Exclude registry flavor + arm64 architecture combination from matrix.
Missed this in original pre release testing changes.

## Related Issue

Relates to #84 

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-mattermost/blob/main/CONTRIBUTING.md#developer-workflow)
followed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment