Pepr error event/msg on client creation failure can be misleading

[mjnagel]

Describe what should be investigated or refactored

Currently we have a catchall for all any Keycloak client creation failures that logs an error "Failed to process client request ... This can occur if a client already exists with the same ID that Pepr isn't tracking.".

This error is often misleading because it can surface for any number of reasons that the client creation was invalid (client scopes, invalid URIs, etc). The result is a confusing error message and the real error message is only visible in the Keycloak logs themselves. It would be good to revisit this catch all and see if we can filter errors or better represent the true failure on the keycloak call.

Links to any relevant code

uds-core/src/pepr/operator/controllers/keycloak/client-sync.ts

Lines 128 to 142 in 434844b

	} catch (err) {
	const msg =
	`Failed to process client request '${clientReq.clientId}' for ` +
	`${pkg.metadata?.namespace}/${pkg.metadata?.name}. This can occur if a client already exists with the same ID that Pepr isn't tracking.`;
	Log.error({ err }, msg);
	if (isRetry) {
	Log.error(`${msg}, retry failed, aborting`);
	throw new Error(`${msg}. RETRY FAILED, aborting: ${JSON.stringify(err)}`);
	}
	// Retry the request
	Log.warn(`${msg}, retrying`);
	return syncClient(clientReq, pkg, true);
	}