Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match OpenCV to grayscale algorithm, #964 #965

Merged
merged 1 commit into from
May 19, 2021

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: I3e7ae2731d4ad36e3cbe27ec4a2ebd0bc3749ccd
@zachgk zachgk linked an issue May 18, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021

Codecov Report

Merging #965 (48d9fbf) into master (c17c15a) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #965      +/-   ##
============================================
- Coverage     70.24%   70.20%   -0.04%     
+ Complexity     5091     5088       -3     
============================================
  Files           502      502              
  Lines         22479    22479              
  Branches       2348     2348              
============================================
- Hits          15790    15782       -8     
- Misses         5444     5451       +7     
- Partials       1245     1246       +1     
Impacted Files Coverage Δ Complexity Δ
.../java/ai/djl/modality/cv/BufferedImageFactory.java 72.44% <100.00%> (ø) 10.00 <0.00> (ø)
api/src/main/java/ai/djl/training/Trainer.java 91.83% <0.00%> (-3.07%) 33.00% <0.00%> (-1.00%)
api/src/main/java/ai/djl/inference/Predictor.java 87.50% <0.00%> (-2.89%) 23.00% <0.00%> (-1.00%)
.../src/main/java/ai/djl/repository/zoo/Criteria.java 89.84% <0.00%> (-1.57%) 24.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17c15a...48d9fbf. Read the comment docs.

@frankfliu frankfliu merged commit d7ef4ec into deepjavalibrary:master May 19, 2021
@frankfliu frankfliu deleted the cv branch May 19, 2021 00:21
Lokiiiiii pushed a commit to Lokiiiiii/djl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lower accuracy when i use djl api to inference
3 participants