[rust] RsModel delete model in close #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyang16
force-pushed
the
rust
branch
2 times, most recently
from
3780fe3
to
780a6e4
Compare
frankfliu
reviewed
May 10, 2024
extensions/tokenizers/src/main/java/ai/djl/engine/rust/RsModel.java
Outdated
Show resolved
Hide resolved
| /** {@inheritDoc} */ | ||
| @Override | ||
| public void close() { | ||
| if (handle != -1) { |
There was a problem hiding this comment.
Long pointer = handle.getAndSet(null);
if (pointer != null) {
RustLibrary.deleteModel(handle);
}
59905d6
to
e970288
Compare
frankfliu
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about