Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api] Closes file stream #3130

Merged
merged 1 commit into from
Apr 30, 2024
Merged

[api] Closes file stream #3130

merged 1 commit into from
Apr 30, 2024

Conversation

frankfliu
Copy link
Contributor

Fixes #3127

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners April 25, 2024 15:16
@xyang16
Copy link
Contributor

xyang16 commented Apr 29, 2024

This PR has a lot of other commits in it.

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 29, 2024
View reviewed changes
api/src/main/java/ai/djl/util/Utils.java Dismissed Show dismissed Hide dismissed
@frankfliu frankfliu merged commit c54db65 into deepjavalibrary:master Apr 30, 2024
5 checks passed
@frankfliu frankfliu deleted the stream branch April 30, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyang16 xyang16 xyang16 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource Leak Issue with Files.list in ai.djl.util.Utils
2 participants
@frankfliu @xyang16