Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pytorch] Fixes windows load nvfuser_codegen bug #2868

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Attention: 1365 lines in your changes are missing coverage. Please review.

Comparison is base (bb5073f) 72.08% compared to head (435e19e) 72.31%.
Report is 920 commits behind head on master.

Files Patch % Lines
...va/ai/djl/modality/nlp/generate/TextGenerator.java 2.81% 276 Missing ⚠️
.../java/ai/djl/modality/nlp/generate/SeqBatcher.java 0.75% 132 Missing ⚠️
...ity/nlp/generate/ContrastiveSeqBatchScheduler.java 2.97% 98 Missing ⚠️
...i/djl/modality/nlp/generate/SeqBatchScheduler.java 9.83% 55 Missing ⚠️
.../java/ai/djl/modality/cv/BufferedImageFactory.java 40.96% 47 Missing and 2 partials ⚠️
...a/ai/djl/modality/nlp/generate/StepGeneration.java 2.04% 48 Missing ⚠️
api/src/main/java/ai/djl/ndarray/NDArray.java 43.42% 39 Missing and 4 partials ⚠️
...n/java/ai/djl/modality/cv/output/CategoryMask.java 22.00% 39 Missing ⚠️
...i/src/main/java/ai/djl/ndarray/NDArrayAdapter.java 71.21% 31 Missing and 7 partials ⚠️
.../cv/translator/SemanticSegmentationTranslator.java 37.50% 35 Missing ⚠️
... and 76 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2868      +/-   ##
============================================
+ Coverage     72.08%   72.31%   +0.22%     
- Complexity     5126     7163    +2037     
============================================
  Files           473      708     +235     
  Lines         21970    31914    +9944     
  Branches       2351     3313     +962     
============================================
+ Hits          15838    23078    +7240     
- Misses         4925     7259    +2334     
- Partials       1207     1577     +370     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enpasos
Copy link
Contributor

enpasos commented Nov 23, 2023

Thx, a lot for the fix and for supporting PyTorch 2.1.1!
It works nicely on my stack

https://github.com/enpasos/muzero  with  
djl = "0.26.0-SNAPSHOT"
pytorch = "2.1.1-SNAPSHOT"
on
cudnn-windows-x86_64-8.9.6.50_cuda12
cuda_12.1.1_531.14
Windows 11 Pro, 23H2, 22631.2715

@frankfliu frankfliu merged commit bb56edc into deepjavalibrary:master Nov 28, 2023
5 checks passed
@frankfliu frankfliu deleted the pt branch November 28, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants