Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Utils.getEnvOrSystemProperty with default #2742

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Aug 9, 2023

Adds the Utils.getEnvOrSystemProperty that also supports a default value.

Adds the Utils.getEnvOrSystemProperty that also supports a default value.
@zachgk zachgk requested review from frankfliu and a team as code owners August 9, 2023 23:13
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Patch coverage: 54.72% and project coverage change: +0.05% 🎉

Comparison is base (bb5073f) 72.08% compared to head (3f2dda8) 72.14%.
Report is 865 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2742      +/-   ##
============================================
+ Coverage     72.08%   72.14%   +0.05%     
- Complexity     5126     7032    +1906     
============================================
  Files           473      698     +225     
  Lines         21970    31292    +9322     
  Branches       2351     3230     +879     
============================================
+ Hits          15838    22576    +6738     
- Misses         4925     7174    +2249     
- Partials       1207     1542     +335     
Files Changed Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...djl/modality/cv/transform/RandomFlipLeftRight.java 25.00% <0.00%> (-25.00%) ⬇️
...djl/modality/cv/transform/RandomFlipTopBottom.java 25.00% <0.00%> (-25.00%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
.../modality/cv/translator/ImageFeatureExtractor.java 0.00% <0.00%> (ø)
.../ai/djl/modality/cv/translator/YoloTranslator.java 27.77% <0.00%> (+18.95%) ⬆️
...ain/java/ai/djl/modality/cv/util/NDImageUtils.java 67.10% <0.00%> (+7.89%) ⬆️
api/src/main/java/ai/djl/modality/nlp/Decoder.java 63.63% <ø> (ø)
... and 226 more

... and 368 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachgk zachgk merged commit ff66278 into deepjavalibrary:master Aug 9, 2023
5 checks passed
@zachgk zachgk deleted the envSysDef branch August 9, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants