Fix issue with setPadding and setTruncation overriding configurations… #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgk
reviewed
Aug 9, 2023
| String[] expected = { | ||
| "<s>", "▁", "test", "▁sentence", "</s>", "<pad>", "<pad>", "<pad>" | ||
| }; | ||
| System.out.println(Arrays.toString(tokens)); |
… set in tokenizer.json
zachgk
approved these changes
Aug 9, 2023
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #2741 +/- ##
============================================
+ Coverage 72.08% 72.15% +0.06%
- Complexity 5126 7029 +1903
============================================
Files 473 698 +225
Lines 21970 31282 +9312
Branches 2351 3228 +877
============================================
+ Hits 15838 22570 +6732
- Misses 4925 7171 +2246
- Partials 1207 1541 +334
☔ View full report in Codecov by Sentry. |
frankfliu
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… set in tokenizer.json
Description
This fixes an issue where our implementation of Tokenizer overwrites any padding or truncation configuration set in the
tokenizer.jsonfile.I have added a fake tokenizer.json here to validate with a unit test.
Fixes #2669