-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding semantic segmentation example #1764
Conversation
Let add images to S3 bucket |
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslator.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/ai/djl/examples/inference/SemanticSegmentation.java
Outdated
Show resolved
Hide resolved
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslatorFactory.java
Outdated
Show resolved
Hide resolved
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslator.java
Outdated
Show resolved
Hide resolved
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslator.java
Show resolved
Hide resolved
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslator.java
Show resolved
Hide resolved
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslator.java
Outdated
Show resolved
Hide resolved
api/src/main/java/ai/djl/modality/cv/translator/SemanticSegmentationTranslator.java
Outdated
Show resolved
Hide resolved
} | ||
|
||
/** Resizes the image based on the shorter edge or maximum edge length. */ | ||
private class ResizeShort implements Transform { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private class ResizeShort implements Transform { | |
private static final class ResizeShort implements Transform { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ResizeShort class from the InstanceSegmentationTranslator is not static or final, and by making it static, the shortEdge
, maxEdge
, rescaledHeight
, and rescaledWidth
variables must be initialized at the beginning of the file. If I make it static, what values should they be assigned?
Codecov Report
@@ Coverage Diff @@
## master #1764 +/- ##
============================================
- Coverage 72.08% 69.68% -2.41%
- Complexity 5126 5485 +359
============================================
Files 473 524 +51
Lines 21970 24272 +2302
Branches 2351 2640 +289
============================================
+ Hits 15838 16913 +1075
- Misses 4925 6048 +1123
- Partials 1207 1311 +104
Continue to review full report at Codecov.
|
Co-authored-by: Frank Liu <frankfliu2000@gmail.com>
Ran ./gradlew fJ and this was the fix
Change-Id: Iec3943455cb58dc0d8644841446cb3d91242bb20
Description
Brief description of what this PR is about
Adding semantic segmentation example which includes: