[ci] Fixes PMD warnings

deepjavalibrary · Aug 23, 2023 · c0d67cb · c0d67cb
1 parent 59af05f
commit c0d67cb
Show file tree

Hide file tree

Showing 12 changed files with 15 additions and 9 deletions.
diff --git a/.github/workflows/continuous.yml b/.github/workflows/continuous.yml
@@ -82,10 +82,10 @@ jobs:
         run: ./gradlew :engines:paddlepaddle:paddlepaddle-native:compileJNI
       - name: Test ONNX Runtime
         run: |
-          ./gradlew -Dai.djl.default_engine=OnnxRuntime :integration:test
+          ./gradlew --stacktrace -Dai.djl.default_engine=OnnxRuntime :integration:test
           ./gradlew :integration:clean
       - name: Build with Gradle
-        run: ./gradlew build :jacoco:testCodeCoverageReport
+        run: ./gradlew --stacktrace build :jacoco:testCodeCoverageReport
       - name: Upload test results
         uses: actions/upload-artifact@v3
         if: always()
@@ -158,6 +158,6 @@ jobs:
       - name: Integration tests
         # MXNet integration test on Github Action fail due to memory limitation on Windows
         run: |
-          ./gradlew -Pjni "-Dai.djl.default_engine=PyTorch" test -x examples:test
-          ./gradlew -Pjni --rerun-tasks "-Dai.djl.default_engine=TensorFlow" test -x examples:test
-          ./gradlew --rerun-tasks "-Dai.djl.default_engine=OnnxRuntime" :integration:test
+          ./gradlew -Pjni "-Dai.djl.default_engine=PyTorch" --stacktrace test -x examples:test
+          ./gradlew -Pjni --rerun-tasks --stacktrace "-Dai.djl.default_engine=TensorFlow" test -x examples:test
+          ./gradlew --rerun-tasks --stacktrace "-Dai.djl.default_engine=OnnxRuntime" :integration:test
diff --git a/api/src/main/java/ai/djl/training/Trainer.java b/api/src/main/java/ai/djl/training/Trainer.java
@@ -281,7 +281,7 @@ public List<Evaluator> getEvaluators() {
      *
      * @param listenerConsumer a consumer that executes the method
      */
-    public void notifyListeners(Consumer<TrainingListener> listenerConsumer) {
+    public final void notifyListeners(Consumer<TrainingListener> listenerConsumer) {
         listeners.forEach(listenerConsumer);
     }
 

diff --git a/api/src/test/java/ai/djl/nn/BlockFactoryTest.java b/api/src/test/java/ai/djl/nn/BlockFactoryTest.java
@@ -20,6 +20,7 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 
+@SuppressWarnings("PMD.TestClassWithoutTestCases")
 public class BlockFactoryTest {
 
     @Test

diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-bin.zip
diff --git a/integration/src/main/java/ai/djl/integration/IntegrationTest.java b/integration/src/main/java/ai/djl/integration/IntegrationTest.java
@@ -51,6 +51,7 @@
 import java.util.jar.JarFile;
 import java.util.stream.Collectors;
 
+@SuppressWarnings("PMD.TestClassWithoutTestCases")
 public class IntegrationTest {
 
     private static final Logger logger = LoggerFactory.getLogger(IntegrationTest.class);

diff --git a/integration/src/main/java/ai/djl/integration/tests/inference/StreamingTest.java b/integration/src/main/java/ai/djl/integration/tests/inference/StreamingTest.java
@@ -35,6 +35,7 @@
 import java.util.List;
 import java.util.stream.Stream;
 
+@SuppressWarnings("PMD.TestClassWithoutTestCases")
 public class StreamingTest {
 
     @Test

diff --git a/integration/src/main/java/ai/djl/integration/tests/nn/BlockFactoryTest.java b/integration/src/main/java/ai/djl/integration/tests/nn/BlockFactoryTest.java
@@ -99,6 +99,7 @@ private Path prepareModel(Path savedDir) throws IOException, ModelException {
         return zipPath;
     }
 
+    @SuppressWarnings("PMD.TestClassWithoutTestCases")
     public static class TestBlockFactory implements BlockFactory {
 
         private static final long serialVersionUID = 1234567L;

diff --git a/...gration/src/main/java/ai/djl/integration/tests/nn/ScaledDotProductAttentionBlockTest.java b/...gration/src/main/java/ai/djl/integration/tests/nn/ScaledDotProductAttentionBlockTest.java
@@ -30,6 +30,7 @@
 import org.testng.Assert;
 import org.testng.annotations.Test;
 
+@SuppressWarnings("PMD.TestClassWithoutTestCases")
 public class ScaledDotProductAttentionBlockTest {
 
     private double[] keySequenceInitialization = {

diff --git a/integration/src/main/java/ai/djl/integration/util/TestUtils.java b/integration/src/main/java/ai/djl/integration/util/TestUtils.java
@@ -20,6 +20,7 @@
 
 import java.util.Arrays;
 
+@SuppressWarnings("PMD.TestClassWithoutTestCases")
 public final class TestUtils {
 
     private static String engineName = Engine.getDefaultEngineName();

diff --git a/testing/src/main/java/ai/djl/testing/CoverageUtils.java b/testing/src/main/java/ai/djl/testing/CoverageUtils.java
@@ -39,7 +39,7 @@
 import java.util.jar.JarFile;
 import java.util.stream.Collectors;
 
-@SuppressWarnings("PMD.AvoidAccessibilityAlteration")
+@SuppressWarnings({"PMD.AvoidAccessibilityAlteration", "PMD.TestClassWithoutTestCases"})
 public final class CoverageUtils {
 
     private CoverageUtils() {}

diff --git a/testing/src/main/java/ai/djl/testing/TestRequirements.java b/testing/src/main/java/ai/djl/testing/TestRequirements.java
@@ -24,6 +24,7 @@
  * <p>When the test requirements are not fulfilled, the test is skipped with a {@link
  * SkipException}.
  */
+@SuppressWarnings("PMD.TestClassWithoutTestCases")
 public final class TestRequirements {
 
     private TestRequirements() {}

diff --git a/tools/conf/pmd.xml b/tools/conf/pmd.xml
@@ -407,7 +407,6 @@
         <exclude name="AvoidFieldNameMatchingTypeName"/>
         <exclude name="AvoidInstanceofChecksInCatchClause"/>
         <exclude name="AvoidLiteralsInIfCondition"/>
-        <exclude name="BeanMembersShouldSerialize"/>
         <exclude name="CloneMethodMustImplementCloneable"/>
         <exclude name="CloseResource"/>
         <exclude name="CompareObjectsWithEquals"/>