Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.0.0 update! #19

Merged
merged 108 commits into from
Jul 30, 2017
Merged

v3.0.0 update! #19

merged 108 commits into from
Jul 30, 2017

Conversation

nicolas-goudry
Copy link
Collaborator

@nicolas-goudry nicolas-goudry commented Jul 23, 2017 •
edited
Loading

Okay, here is the v3.0.0 update!

Featuring HOC_transform: (see issue #9)

  • SocialLogin has been fully rewritten and is now an HOC
  • SocialUser has been simplified and is now in a separate file (better version control)
  • Loaders are now SDKs as they handle login process triggering and any action related to SDK
  • Kept old component version as a fallback (named export OldSocialLogin)
  • Updated demo and added demo for old component version
  • Updated README (you’ll love it 😉)

Featuring new providers:

Featuring new features:

  • Auto login
  • Auto URI cleaning after OAuth callback mess
  • User choose how and when to trigger login process (see issue Make it work with all events #16)
  • Better error handling (I think 😂)

Featuring fixes:

@nicolas-goudry
Rename loaders as they now handle more than loading SDK
da79fb3 
Update FB file for tests
@nicolas-goudry
Transform classic React component to React HOC
a7250be
@nicolas-goudry
Update demo according to last changes
528da7f
@nicolas-goudry
Remove logs
bafe6e7
@nicolas-goudry
Fix wrong props usage
ed2529d
@nicolas-goudry
Update demo
34f0905
@nicolas-goudry
Forward original component props
b645823
@nicolas-goudry
Enhance code style and var names
12ebbb2
@nicolas-goudry
Update demo
816486f
@nicolas-goudry
Remove commented code
030397b
@nicolas-goudry
CheckLogin reject Promise if user not connected
bbf342c
@nicolas-goudry
Fix wrong autologin use
422b9f9
@nicolas-goudry
Moved SocialUser class to its own file
fd934ee 
Also simplify the class as a minimal helper
@nicolas-goudry
Update FB SDK loader
e34b3ff
@nicolas-goudry
Generate SocialUser data through SDK function
c384234
@nicolas-goudry
Upgrade Google SDK helper
1279736
@nicolas-goudry
Fix an error with Google SDK loader never being declared loaded
a5bb6ba
@nicolas-goudry
Update demo
1426c90
@nicolas-goudry
Remove autologin as default prop
831b583
@nicolas-goudry
Change forwarded prop name onClick to triggerLogin
d890360
@nicolas-goudry
Add React PropTypes package and npm5 lockfile
fbdcf61
@nicolas-goudry
Use new React PropTypes package
12cc95f
@nicolas-goudry
Remove version prop as it is not used
8e5d272
@nicolas-goudry
Update Facebook SDK version
0f08f30
@nicolas-goudry
Comments, comments, comments!
838c764
@nicolas-goudry
Added pre-commit
4b60da9
@nicolas-goudry
Lint code before commiting
db85742
@nicolas-goudry
Don’t force protocol
fc14347
@nicolas-goudry
Update Google login process
6505efa
@nicolas-goudry
Move load check at function top
3d0fcab
carldunham
carldunham reviewed Jul 27, 2017
View reviewed changes
src/sdk/github.js Outdated
})

/**
* Checks if user is logged in to app through LinkedIn.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/LinkedIn/GitHub 😸

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/paste trap 😄 See 93f1b9f

@nicolas-goudry nicolas-goudry mentioned this pull request Jul 28, 2017
Closed
@deepakaggarwal7 deepakaggarwal7 merged commit 68813cf into deepakaggarwal7:master Jul 30, 2017
@nicolas-goudry nicolas-goudry deleted the v3/HOC+Instagram+GitHub branch July 30, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carldunham carldunham carldunham left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolas-goudry @deepakaggarwal7 @carldunham