Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses cython only if present. #8

Closed

Conversation

alexis-mignon
Copy link

@alexis-mignon alexis-mignon commented Apr 14, 2018

Check whether cython is installed or not. If so, comilation is performed from the .pyx file, otherwise from the .c file.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8e48103 on alexis-mignon:setup_with_cython into 74a389b on dedupeio:master.

@coveralls
Copy link

coveralls commented Apr 14, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling d65403a on alexis-mignon:setup_with_cython into 74a389b on dedupeio:master.

@alexis-mignon
Copy link
Author

Looks like there are problems with the continuous integration:

  • The upgrade of pip fails in Travis
  • The include dir for stdint does not seem to be added in appveyor.

@alexis-mignon
Copy link
Author

alexis-mignon commented Apr 14, 2018

  • Looks like the NumpyExtension class does not have the same behaviour in python 2 and 3. For python 2 case, when used with cython, it leaded to compat/win32 not being added to include dirs.

  • The error in travis is due do pip not being installed when compiling for osX, or maybe pip2 or pip3 should be used instead of pip: OSX: pip command not found travis-ci/travis-ci#8829

@fgregg
Copy link

fgregg commented Apr 17, 2018

thanks! merged your changes in another branch

@fgregg fgregg closed this Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants