Model refactor #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactored all models to handle entire batches of metadata instead of just the ones of interest. * Added 4 new models. * Renamed the KeyAdd model to KeyAdd_weight to more accurately depict what it is doing. * Refactored all engines that interact with metadata to pass in the full batch of metadate to a model.
* Changed all instances of byte/byte_pos/byte_position(s) to model_postion/model_pos. * Changed all instances of model to model_value. * Renamed the models folder to model_values. * Added a new model_value base class guess_model_value. * Generic renaming to increase clarity.
* Changed the name of the model constructor argument to be model_value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.