Engine Linting Issues and Naming Fix #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
boslandj
commented
Jan 27, 2024
•
boslandj
commented
- Removed all instances of _get_result()
- Changed all instances of _run to run_workload
- Changed all instances of _get_candidate to find_candidate
- Changed _result in the Engine to tmp_result
- Removed internal_state_update from CPA
- Fixed all flake8 linting issues with the following files : cpa.py, NICV.py, engine.py, mia.py, mim.py, snr.py, stats.py, ttest.py.
- Removed all instances of _get_result() - Changed all instances of _run to run_workload - Changed all instances of _get_candidate to find_candidate - Changed _result in the Engine to tmp_result - Removed internal_state_update from CPA
added 11 commits
January 27, 2024 12:17
- Fixed all flake8 linting issues
-Removed one more linting issue in NICV.py -Fixed linting issues with cpa.py
- Fixed linting issues with cpa.py
- Fixed linting issues in file engine.py
-Fixed linting issues in mia.py -Fixed one additional linting issue in cpa.py
-Linting issue fixes for mia.py
-Linting issue fixes for mim.py -One linting issue fix for mia.py
-Fixed linting issues for file snr.py -Fixed one linting issue in file mim.py
-Fixed linting issues in file stats.py -Fixed one linting issue in file snr.py
-Fixed linting issues in file ttest.py
-Fixed two linting issues in file ttest.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.