Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vdsnapshot): fix no bootable device error #421

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix(vdsnapshot): fix no bootable device error #421

merged 1 commit into from
Oct 4, 2024
+77 −83

Conversation

Isteb4k
Copy link
Contributor

@Isteb4k Isteb4k commented Oct 4, 2024 •
edited
Loading

Description

  1. Fix no bootable device error (wrong api group for pvc)
  2. Fix unfreeze for disk devices
  3. Improve crd description

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@Isteb4k Isteb4k marked this pull request as ready for review October 4, 2024 06:59
LopatinDmitr
LopatinDmitr previously approved these changes Oct 4, 2024
View reviewed changes
@Isteb4k Isteb4k force-pushed the fix/vdsnapshot/no-bootable-device branch from ccd140d to 5cac461 Compare October 4, 2024 07:44
yaroslavborbat
yaroslavborbat previously approved these changes Oct 4, 2024
View reviewed changes
@Isteb4k Isteb4k force-pushed the fix/vdsnapshot/no-bootable-device branch 3 times, most recently from 80a2e91 to 7ae57a9 Compare October 4, 2024 10:26
@Isteb4k @universal-itengineer
fix(vdsnapshot): fix no bootable device error
6301200 
Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
@Isteb4k Isteb4k changed the base branch from main to release-0-13-2 October 4, 2024 10:39
@universal-itengineer universal-itengineer added the build/self-hosted/virt-runners Run jobs on virtualization git hub runners label Oct 4, 2024
@Isteb4k Isteb4k merged commit 6ae5351 into release-0-13-2 Oct 4, 2024
22 of 26 checks passed
@Isteb4k Isteb4k deleted the fix/vdsnapshot/no-bootable-device branch October 4, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@universal-itengineer universal-itengineer universal-itengineer approved these changes

@yaroslavborbat yaroslavborbat yaroslavborbat left review comments

@LopatinDmitr LopatinDmitr LopatinDmitr left review comments

Assignees

@Isteb4k Isteb4k

Labels
build/self-hosted/virt-runners Run jobs on virtualization git hub runners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Isteb4k @yaroslavborbat @LopatinDmitr @universal-itengineer