Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get_signature_count method #31

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Oct 21, 2022

Closes #29

The current version of sapp takes into account such depth in functions get_xref_* but does not store the depth of the document. Maybe you can try to store it and see if that meets your requirements. If so, please create a pull request.

@dealfonso i don't know if I understood the idea correctly but it seems to be working, I tried signing one, two and three times and it always returns the correct number of signatures

@dealfonso
Copy link
Owner

Your method counts the number of signature fields in the document... I suppose that it is fine, but let me think about it.

@erikn69
Copy link
Contributor Author

erikn69 commented Oct 25, 2022

@dealfonso new idea, how about get subject and issuer data as info, example

/* 
  @returns array [
    0 => [ 'issuer' => $array_issuer1, 'subject' => $array_subject1],
    1 => [ 'issuer' => $array_issuer2, 'subject' => $array_subject2],
    ...
  ]
*/
public function get_signatures {
    return $this->_signatures; 
}

@dealfonso
Copy link
Owner

I like this solution. Nice work!

@dealfonso dealfonso merged commit 7782f7f into dealfonso:main Oct 26, 2022
@erikn69 erikn69 deleted the patch-4 branch October 27, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get signatures count method
2 participants