Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for async signature computation #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rpuch
Copy link

@rpuch rpuch commented Apr 3, 2019

In WebCrypto API, all the operations, including signature computation, are async and return promises. Trying to implement RSA-SHA1 signature method, I found out that it was impossible to do because the library always uses getSignature() in a synchronous manner.

The idea is to add an async method that is able to work with async getSignature() (and getBodyHash()) methods.

Please note that I did not add anything to the TS file. Could you please give me a hint: what changes are to be added there?

@ddo
Copy link
Owner

ddo commented Jun 5, 2019

pls check the ci test fail

@rpuch
Copy link
Author

rpuch commented Jun 8, 2019

@ddo done, the tests have passed

@voxxit
Copy link

voxxit commented Aug 16, 2022

Bump?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants