Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the link for new Discussion #4216

Merged
merged 14 commits into from
Oct 9, 2023
Merged

Conversation

asarraf
Copy link
Contributor

@asarraf asarraf commented Oct 7, 2023

What are you changing in this pull request and why?

Based on the discussion here: #2553
The discourse will be the new forum where one can discuss new ideas.

This PR replaces the previous link to start a new discussion to the discourse link

@asarraf asarraf requested a review from a team as a code owner October 7, 2023 00:53
@welcome
Copy link

welcome bot commented Oct 7, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel
Copy link

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 1 unresolved Oct 9, 2023 9:17am

@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 7, 2023
@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address and removed new contributor Label for first-time contributors labels Oct 7, 2023
@asarraf
Copy link
Contributor Author

asarraf commented Oct 7, 2023

It says there is 1 unresolved Comment. How I can access my Versel account as it is pending approval for access?

@asarraf
Copy link
Contributor Author

asarraf commented Oct 8, 2023

@mirnawong1: Can you please review?

@mirnawong1 mirnawong1 added the new contributor Label for first-time contributors label Oct 9, 2023
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @anksu2024, thanks so much for opening this pr and great work here! I've reviewed it and made some small tweaks and wanted to clarify a few things as well:

  • any questions on solutions, sharing best practices, etc. -- we recommend users open up discussions in the dbt community forum in discourse. this would
  • any feedback, questions, requests, etc. for the dbt product docs (docs.getdbt.com site) -- we recommend users open an issue in the github repository.

i wanted to clarify that the developer hub is all of https://docs.getdbt.com/ site, which includes the product docs, developer blog, guides, and so on. the dbt community forum is a place where you can get help and exchange knowledge with other data practitioners.

there were some places in the suggested changes that i updated to point to the docs.getdbt.com issues. it previously directed users to 'discussions' which wasn't correct either! i hope that clarifies it and i appreciate the awesome attention to detail in this pr. let me know if you have any questions at all!

I'll go ahead and merge this pr for you ✨

.github/ISSUE_TEMPLATE/improve-the-site.yml Outdated Show resolved Hide resolved
@mirnawong1 mirnawong1 merged commit 5aa0bf1 into dbt-labs:current Oct 9, 2023
4 checks passed
@asarraf
Copy link
Contributor Author

asarraf commented Oct 9, 2023

Thanks @mirnawong1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants