Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Link? Open a discussion on the Developer Hub #4178

Closed
1 task done
asarraf opened this issue Oct 4, 2023 · 7 comments
Closed
1 task done

Broken Link? Open a discussion on the Developer Hub #4178

asarraf opened this issue Oct 4, 2023 · 7 comments
Labels
bug Something isn't working engineering improvement that requires site engineering help or back up

Comments

@asarraf
Copy link
Contributor

asarraf commented Oct 4, 2023

Contributions

  • I have read the contribution docs, and understand what's expected of me.

What page(s) or areas on docs.getdbt.com are affected?

The affected page

When I click on the link Open a discussion on the Developer Hub, I am directed to the below page:

Screenshot 2023-10-03 at 7 06 39 PM

It seems like broken.

What changes are you suggesting?

There are 2 ways to fix this that I can think of:

  1. Either put the correct link which takes one to the page to open the discussion
  2. If this issue is arising because of some permission issue, then that can be mentioned somewhere on the doc.

Additional information

No response

@asarraf asarraf added bug Something isn't working engineering improvement that requires site engineering help or back up labels Oct 4, 2023
@asarraf
Copy link
Contributor Author

asarraf commented Oct 4, 2023

Change might be required on these 2 lines:

  1. Have you seen things in other OSS projects that you quite like, and think we could learn from? [Open a discussion on the Developer Hub](https://github.com/dbt-labs/docs.getdbt.com/discussions/new), or start a conversation in the dbt Community Slack (for example: `#community-strategy`, `#dbt-core-development`, `#package-ecosystem`, `#adapter-ecosystem`). We always appreciate hearing from you!
  2. - Issues are **not** for support / troubleshooting / debugging help. Please [open a discussion on the Developer Hub](https://github.com/dbt-labs/docs.getdbt.com/discussions/new), so other future users can find and read proposed solutions. If you need help formulating your question, you can post in the `#advice-dbt-help` channel in the [dbt Community Slack](https://www.getdbt.com/community/).

@mirnawong1
Copy link
Contributor

hey @anksu2024 , thanks so much for flagging this! I believe discourse is the right place to open up a discussion, however, i'm double checking this before i make any changes to the page. much appreciated! ✨

@asarraf
Copy link
Contributor Author

asarraf commented Oct 5, 2023

@mirnawong1
Are you trying to convey that the Open a discussion on the Developer Hub is actually expected to redirect to the Discourse page?

If yes, I can make that change happen marking my first materialized open source Contribution.

@mirnawong1
Copy link
Contributor

mirnawong1 commented Oct 6, 2023

hey @anksu2024 ! i'm so glad to hear you'd like to make your first contribution ✨! So this page (inc the paragraph below and this section on the page) should link to discourse to start a discussion.

you can absolutely open up a pr and make those changes -- we would really appreciate it!

So it should read something like this:

Have you seen things in other OSS projects that you quite like, and think we could learn from? Open a discussion on the Developer Hub, or start a conversation in the dbt Community Slack (for example: #community-strategy, #dbt-core-development, #package-ecosystem, #adapter-ecosystem). We always appreciate hearing from you!

@mirnawong1
Copy link
Contributor

let me know if you need any help at all!

@asarraf
Copy link
Contributor Author

asarraf commented Oct 7, 2023

Created new PR #4216

@asarraf
Copy link
Contributor Author

asarraf commented Oct 10, 2023

Resolved closing the issue

@asarraf asarraf closed this as completed Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working engineering improvement that requires site engineering help or back up
Projects
None yet
Development

No branches or pull requests

2 participants