Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated for Python 3.11, type annotations, refactoring #5

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jackjansen
Copy link

I'm not sure if you're interested in my changes (I can imagine that you're not, and I won't be sad if you won't pick them up:-), but I thought I'd share them with you anyway. It's become a bit more than I initially envisioned...

This is an updated version of my previous pull request #4, the only difference is it uses a different branch so I can use my own master branch for further work.

  • Updated Python packages to Python 3.11, including API changes for some
  • Added some type annotations so editing in vscode becomes quite a bit easier with hints and such
  • Refactored so there are now distinct steps to
    • create the colormapping curves, and
    • apply those curves to the source image
  • Added a debug option to optionally show the aruco finder results and the mapping curves

The next thing I'm going to do is probably another step of refactoring, to turn the whole thing into a class so that you can use distinct steps of (1) creating the colormaps and (2) mapping the images. This should allow reuse of a single colormap for multiple images. But that's for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant