✨ Allows getBlock to find block by hash
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dawsbot
reviewed
Apr 24, 2022
| @@ -67,6 +67,15 @@ describe('provider.getBlock happy path', () => { | |||
| testBlockEquality(eeRandomBlock, web3RandomBlock); | |||
| // expect(eeRandomBlock).toStrictEqual(web3RandomBlock); | |||
| }); | |||
| const blockHash = | |||
There was a problem hiding this comment.
Great test case!
I have never heard of or used RSK by the way, it's just the slowest block times I could find, which makes our other tests case which relies on "latest" fail less often. In the future we can always prefer eth mainnet for static data like this which never changes. It's the most-reliable chain when we have no idea if these smaller chains will still exist in many years 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now allows calls like:
Closes #92
getBlockto also accept blocks specified by hash