Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallthrough RPC provider #90

Merged
merged 18 commits into from
Apr 26, 2022
Merged

Fallthrough RPC provider #90

merged 18 commits into from
Apr 26, 2022

Conversation

dawsbot
Copy link
Owner

@dawsbot dawsbot commented Apr 22, 2022

Closes #22

  • Timeout (if the URL takes 10+ seconds)
  • Consider singletons (a shared memory for current index will be critical to success)
  • Consider a mutex or lock on the add such that adding to the rpc counter can happen max once per 10 seconds (give or take)

@vercel
Copy link

vercel bot commented Apr 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
essential-eth ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 5:18PM (UTC)

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #90 (58a7c49) into master (2655153) will increase coverage by 0.27%.
The diff coverage is 94.50%.

❗ Current head 58a7c49 differs from pull request most recent head 4bfeb5a. Consider uploading reports for the commit 4bfeb5a to get more accurate results

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   90.51%   90.79%   +0.27%     
==========================================
  Files          28       30       +2     
  Lines         675      717      +42     
  Branches      196      202       +6     
==========================================
+ Hits          611      651      +40     
- Misses         59       61       +2     
  Partials        5        5              
Impacted Files Coverage Δ
src/classes/Contract.ts 100.00% <ø> (ø)
src/utils/solidity-keccak256.ts 87.83% <50.00%> (ø)
src/providers/FallthroughProvider.ts 90.00% <90.00%> (ø)
src/providers/BaseProvider.ts 97.87% <97.87%> (ø)
src/classes/utils/encode-decode-transaction.ts 93.75% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/providers/JsonRpcProvider.ts 100.00% <100.00%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2655153...4bfeb5a. Read the comment docs.

@dawsbot dawsbot changed the title Fallback rpc provider Fallthrough RPC provider Apr 26, 2022
@dawsbot dawsbot deleted the fallback-rpc-provider branch April 26, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FallthroughProvider
1 participant