-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Added getTransaction function #64
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/earnifi/essential-eth/5TDFU6qayywWsTQJXQoKg9dVDYkP |
/** | ||
* Returns information about a specified transaction | ||
* Includes additional information than what is included in the Transaction type | ||
* Similar to `ethers.provider.getTransaction`, some information not included |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed in the diff that data
was in the ethers
response, but not essential-eth
. Do you know how they go that in the response body? Was that two RPC requests that ethers made in-order to give that data back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's just a single request, but they do some processing after the transaction returns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into this a little bit more; ethers returns as data
while essential-eth returns as input
. Both have the same value. Should I alter so that they both call it data
?
Better matches return from ethers
Closes #16.
To-do before merging (will unmark as draft when ready)