Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AlchemyProvider class #205

Merged
merged 9 commits into from
Apr 22, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
RPC_ORIGIN=https://free-eth-node.com
# RPC_ORIGIN=http://localhost:3000
ALCHEMY_API_KEY=kwIkw24q335k05WBuFXBmT3W-P5luv4g
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, this will be botted and spent a ton of $ on immediately @jtfirek

This needs to live in a place that is gitignored, so it never sees the eyes of the public internet. Go cancel this API key immediately. I'll take care of adding it properly to an ignored part of the codebase

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this to my attention @dawsbot! I canceled the API key and will make my own env with the using the .env.example you created!

2 changes: 2 additions & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { BaseContract, Contract } from './classes/Contract';
import { AlchemyProvider } from './providers/AlchemyProvider';
import {
ConstructorOptions,
FallthroughProvider,
Expand Down Expand Up @@ -47,6 +48,7 @@ export {
jsonRpcProvider,
JsonRpcProvider,
FallthroughProvider,
AlchemyProvider,
tinyBig,
toChecksumAddress,
weiToEther,
Expand Down
37 changes: 37 additions & 0 deletions src/providers/AlchemyProvider.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import { BaseProvider } from './BaseProvider';

export class AlchemyProvider extends BaseProvider {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do this entire thing in just 5 lines by extending JsonRpcProvider instead.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this was overengineering @jtfirek. This does the same:

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted @dawsbot! that's much more simplified

/**
* @ignore
*/
selectRpcUrl(): string {
return this._rpcUrls[0];
}

/**
* @ignore
*/
post(body: Record<string, unknown>): Promise<any> {
return this._post(body);
}

/**
* @param apiKey The Alchemy API key
* @param network The Ethereum network to connect to
*/
constructor(apiKey: string, network = 'mainnet') {
const alchemyUrl = `https://eth-${network}.alchemyapi.io/v2/${apiKey}`;
super([alchemyUrl]);
}
}

/**
* Helper function to avoid "new"
*
* @param apiKey the Alchemy API key
* @param network the Ethereum network to connect to
* @returns an initiated {@link AlchemyProvider}
*/
export function alchemyProvider(apiKey: string, network?: string) {
return new AlchemyProvider(apiKey, network);
}
8 changes: 3 additions & 5 deletions src/providers/test/json-rpc-provider/get-block-number.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,9 @@ const mockPostResponse = JSON.stringify({
describe('provider.getBlockNumber', () => {
it('should get number integer', async () => {
const essentialEthProvider = new JsonRpcProvider();
mockOf(unfetch).mockReturnValueOnce(
Promise.resolve({
text: () => mockPostResponse,
} as unknown as Response),
);
mockOf(unfetch).mockResolvedValueOnce({
text: () => mockPostResponse,
} as unknown as Response);
const essentialEthBlockNumber = await essentialEthProvider.getBlockNumber();
expect(essentialEthBlockNumber).toBe(10);
});
Expand Down
8 changes: 3 additions & 5 deletions src/providers/test/json-rpc-provider/get-gas-price.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,9 @@ const rpcUrl = rpcUrls.mainnet;
describe('provider.getGasPrice', () => {
it('should get TinyBig integer', async () => {
const provider = new JsonRpcProvider(rpcUrl);
mockOf(unfetch).mockReturnValueOnce(
Promise.resolve({
text: () => mockPostResponse,
} as unknown as Response),
);
mockOf(unfetch).mockResolvedValueOnce({
text: () => mockPostResponse,
} as unknown as Response);

const gasPrice = await provider.getGasPrice();
expect(z.instanceof(TinyBig).safeParse(gasPrice).success).toBe(true);
Expand Down
20 changes: 20 additions & 0 deletions src/providers/test/test-alchemy-provider.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { AlchemyProvider } from '../../index';
import dotenv from 'dotenv';
dotenv.config();

const apiKey = process.env.ALCHEMY_API_KEY;

if (!apiKey) {
throw new Error(
'ALCHEMY_API_KEY is not defined in the environment variables.',
);
}

const provider = new AlchemyProvider(apiKey);

describe('alchemyProvider.getGasPrice', () => {
it('should return the current gas price', async () => {
const gasPrice = await provider.getGasPrice();
expect(gasPrice).toBeDefined();
});
});