Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed circular dependencies #199

Merged
merged 1 commit into from
Mar 8, 2023
Merged

fixed circular dependencies #199

merged 1 commit into from
Mar 8, 2023

Conversation

jackson-
Copy link
Contributor

@jackson- jackson- commented Mar 7, 2023 •
edited by dawsbot

Closes #156

dawsbot
dawsbot reviewed Mar 7, 2023
View reviewed changes
Copy link
Owner

@dawsbot dawsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but how did you test this @jackson- ? I'd like to ensure the unit tests account for this now

@jackson-
Copy link
Contributor Author

jackson- commented Mar 7, 2023

To be honest, I ran npm run test on the master branch and there are 40+ errors there so I didn't want to take that as my source of truth. I can fix the errors in master to get us to a clean slate btw. Also, the npm run test output doesn't change between branches and Im not changing anything but the import path so I didn't see a need to add more tests.

@dawsbot dawsbot merged commit d2278a9 into dawsbot:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawsbot dawsbot dawsbot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix all circular dependencies
2 participants
@jackson- @dawsbot