-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🦀 SWC Integration #179
🦀 SWC Integration #179
Conversation
test/jest.setup-after-env.js
Outdated
@@ -1,2 +0,0 @@ | |||
// default is 10000 | |||
jest.setTimeout(20000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this removed @turja-c ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test
directory was removed during a previous conflict and experimenting - has been added back now!
.swcrc
Outdated
@@ -0,0 +1,22 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've never needed a .swcrc
before, what happened without this? Some of these settings look like duplicates of the tsconfig
, where-in my normal method of using swc
inherits the tsconfig with no extra files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't previously test without a .swcrc
as I assumed it was needed for specifying the configs. It was repeative information and didn't have an effect on the using swc
.
Main goal was to experiment with .swcrc
and modules to specify commonjs/ems/umd - but realized that it was repetitive and not working
sist output: node
shell
Time created: Fri Dec 09 2022 14:02:12 GMT-0500 (Eastern Standard Time) |
Previously would fail test for provider.getGasPrice as the received time would be less than the expected time. Updated file comments out the expected to be greater than duration.
Updated changes ready for testing! Here is the most recent change that fixed the prior failed tests: 5c8ca32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed import issues for docusaurus and better placement: bb5501b
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Essential Eth Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
The objective is to resolve issue #175 that enables swc for faster build/dev speeds. This swc integration is limited to cjs files (combined with tsc) as swc does not currently offer type declaration (.d.ts files) - based on the comments outlined in this swc issue.