Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦀 SWC Integration #179

Merged
merged 11 commits into from
Dec 20, 2022
Merged

🦀 SWC Integration #179

merged 11 commits into from
Dec 20, 2022

Conversation

tchowd
Copy link
Contributor

@tchowd tchowd commented Dec 8, 2022

The objective is to resolve issue #175 that enables swc for faster build/dev speeds. This swc integration is limited to cjs files (combined with tsc) as swc does not currently offer type declaration (.d.ts files) - based on the comments outlined in this swc issue.

@@ -1,2 +0,0 @@
// default is 10000
jest.setTimeout(20000);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed @turja-c ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test directory was removed during a previous conflict and experimenting - has been added back now!

.swcrc Outdated
@@ -0,0 +1,22 @@
{
Copy link
Owner

@dawsbot dawsbot Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never needed a .swcrc before, what happened without this? Some of these settings look like duplicates of the tsconfig, where-in my normal method of using swc inherits the tsconfig with no extra files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't previously test without a .swcrc as I assumed it was needed for specifying the configs. It was repeative information and didn't have an effect on the using swc.

Main goal was to experiment with .swcrc and modules to specify commonjs/ems/umd - but realized that it was repetitive and not working

@tchowd
Copy link
Contributor Author

tchowd commented Dec 9, 2022

sist output:

node

npm -v: 8.19.2
node --version: v18.11.0

shell

uname: Darwin
echo $SHELL: /bin/zsh
echo $TERM: xterm-256color
echo $TERM_PROGRAM: vscode

Time created: Fri Dec 09 2022 14:02:12 GMT-0500 (Eastern Standard Time)

Previously would fail test for provider.getGasPrice as the received time would be less than the expected time. Updated file comments out the expected to be greater than duration.
@tchowd
Copy link
Contributor Author

tchowd commented Dec 13, 2022

Updated changes ready for testing!

Here is the most recent change that fixed the prior failed tests: 5c8ca32

Copy link
Contributor Author

@tchowd tchowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed import issues for docusaurus and better placement: bb5501b

@dawsbot dawsbot merged commit a680809 into dawsbot:master Dec 20, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 20, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Essential Eth Contributor:

GitPOAP: 2022 Essential Eth Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install and enable swc for faster build/dev speeds [docs] Describe GitPOAP integration
2 participants