🎨 Assorted cleanup #137
Merged
🎨 Assorted cleanup #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 90.71% 90.60% -0.11%
==========================================
Files 38 38
Lines 926 926
Branches 265 264 -1
==========================================
- Hits 840 839 -1
- Misses 76 77 +1
Partials 10 10
Continue to review full report at Codecov.
|
dawsbot
reviewed
May 31, 2022
| // * line break | ||
| // * needs two lines comparing to ethers and web3. Lines need to start with links that have the text Identical, Similar, or Dissimilar that link to /docs/api#isd | ||
| // * Comparing lines need to have links to ethers or web3, and end with either "in ethers.js" or "in web3.js" | ||
| matchDescription: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR was just to clean up some things so they're easier to maintain in the future. This included rewriting a test file, adding a regex pattern for documentation on
BaseProvider.ts, and fixing some types