✨ Add hex number string support to wei converters and estimateGas
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
icepy
changed the title
estimateGas
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 85.65% 85.80% +0.15%
==========================================
Files 37 37
Lines 892 902 +10
Branches 258 259 +1
==========================================
+ Hits 764 774 +10
Misses 113 113
Partials 15 15
Continue to review full report at Codecov.
|
dawsbot
requested changes
May 21, 2022
dawsbot
reviewed
May 21, 2022
src/providers/JsonRpcProvider.ts
Outdated
| @@ -20,6 +23,12 @@ export class JsonRpcProvider extends BaseProvider { | |||
| constructor(rpcUrl = 'https://free-eth-node.com/api/eth') { | |||
| super([rpcUrl]); | |||
| } | |||
|
|
|||
| async estimateGas(transaction: Record<string, unknown>): Promise<TinyBig> { | |||
There was a problem hiding this comment.
This should go in base provider instead so that both JsonRpcProvider and FallthroughProvider get it via inheritance
|
I'll do the rest @icepy 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#120 and #97 @dawsbot pls code review ~