✨ Helper functions related to verifyMessage util fn
#119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added hashMessage to exports * ✨ Added splitSignature util fn * make gas price less flakey * ✨ Added `computeAddress` util fn (#116) * Added initial computeAddress fn, relies on ethers at the moment * Init computePublicKey util fn * ✨ Added computePublicKey util fn * 📝 Added documenation to computePublicKey * ⬆ Pre-commit hook package bump, added @noble/secp256k1 * ✨ Added `computePublicKey` util fn (#118) * Init computePublicKey util fn * ✨ Added computePublicKey util fn * 📝 Added documenation to computePublicKey * ⬆ Pre-commit hook package bump, added @noble/secp256k1 * 🧪 Pass computeAddress test * 📝 Add docs for computeAddress * 📝 Pre-commit script update readme and chains * 🧪 Pass tests with recoverPublicKey * 📝 Pre-commit script readme update Co-authored-by: daws.eth <dawsonbotsford@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
arimgibson
changed the title
verifyMessage util fnverifyMessage util fn
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 91.02% 85.58% -5.45%
==========================================
Files 34 37 +3
Lines 780 888 +108
Branches 220 258 +38
==========================================
+ Hits 710 760 +50
- Misses 64 113 +49
- Partials 6 15 +9
Continue to review full report at Codecov.
|
# Conflicts: # src/index.ts
# Conflicts: # readme.md # scripts/markdown-magic/typedoc.out.json
|
@dawsbot not sure if you saw but I requested you as a reviewer for this PR. I believe it should be ready to merge after you take a peek. The Codecov is bad because of the |
dawsbot
requested changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: this PR was originally intended to close #26. However, because of complex issues with the cryptography, #26 will be put into the
Iceboxsection of theMain Issuesproject to be tackled at a later date. This PR now contains some of the key helper functions created for use in theverifyMessageutility function.computePublicKeyhelper ✨ AddedcomputePublicKeyutil fn #118computeAddresshelper ✨ AddedcomputeAddressutil fn #116splitSignaturehelper ✨ AddedsplitSignatureutil fn #112Additional Tasks
(I was trying to breeze through those tedious helper functions but cut some corners along the way, want to go back and make sure that my tests are thorough and cover a variety of cases & types before this PR is merged)