Make Block tests less fragile

dawsbot · Sep 4, 2022 · 2d62def · 2d62def
1 parent bc46618
commit 2d62def
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/classes/Contract.ts b/src/classes/Contract.ts
@@ -93,7 +93,11 @@ export class BaseContract {
 /**
  * Applies the unique contract's methods to the instantiated Contract in the constructor based-upon the provided ABI
  *
+ * @param object
+ * @param name
+ * @param value
  * @internal
+ * @example
  */
 export function defineReadOnly<T>(object: T, name: string, value: any): void {
   Object.defineProperty(object, name, {

diff --git a/src/providers/test/json-rpc-provider/get-block-number.test.ts b/src/providers/test/json-rpc-provider/get-block-number.test.ts
@@ -13,7 +13,10 @@ describe('provider.getBlockNumber', () => {
       essentialEthProvider.getBlockNumber(),
       ethersProvider.getBlockNumber(),
     ]);
-    expect(essentialEthBlockNumber).toStrictEqual(ethersBlockNumber);
+    // allow one-block flexibility because of timing of requests
+    expect(Math.abs(essentialEthBlockNumber - ethersBlockNumber)).toBeLessThan(
+      2,
+    );
   });
   it('should match web3.js', async () => {
     const essentialEthProvider = new JsonRpcProvider(rpcUrl);