Adding missing implementation of tabbed_display::selected_tab #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for the PR. Yes, the _abstract.h files are documentation. They aren't compiled. This is discussed in the dlib introduction: http://dlib.net/intro.html |
shoeffner
added a commit
to shoeffner/gaze
that referenced
this pull request
Nov 15, 2017
reunanen
pushed a commit
to reunanen/dlib
that referenced
this pull request
Dec 25, 2017
E452003
pushed a commit
to E452003/dlib
that referenced
this pull request
Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a few lines to provide a getter for the selected tab in a tabbed_display.
In
dlib/gui_widgets/widgets_abstract.h:1115there is a getter for the currently selected tab in a tabbed_display. However,widgets.handwidget.cppmissed this, which I figured out when my code wouldn't link properly.Out of curiosity, what is the reason to have basically two almost identical header definitions of the tabbed_display, one in
widgets.hand one inwidgets_abstract.h? The latter seems not to be picked up by the compiler (without my changes inwidgets.hthe new function wouldn't compile) and seems to be there mostly for the documentation purpose?