Fixed support for Node 8.12.0. #172
Conversation
mcollina
force-pushed
the
fix-node-8-12-0
branch
from
11c8943
to
bd949d4
Compare
lib/v8-log-to-ticks.js
Outdated
| @@ -22,8 +43,11 @@ function v8LogToTicks (isolateLogPath, node) { | |||
| // it's an error in the V8 internal tick profiler) | |||
| // ignore them. | |||
| const ignore = /unknown code state:/ | |||
| // pump(sp.stderr, process.stderr) | |||
lib/v8-log-to-ticks.js
Outdated
|
|
||
| module.exports = process | ||
|
|
||
| function process (isolateLogPath, node) { |
There was a problem hiding this comment.
Can we use a different name? Having the same name as global seems not ideal.
lib/v8-log-to-ticks.js
Outdated
| module.exports = process | ||
|
|
||
| function process (isolateLogPath, node) { | ||
| return filterLinesThatAreTooLong(isolateLogPath).then((filtered) => { |
There was a problem hiding this comment.
I suggest to only execute this when it's necessary (by checking the Node.js version).
lib/v8-log-to-ticks.js
Outdated
| return readFile(isolateLogPath, 'utf8').then((data) => { | ||
| data = data.split('\n').filter((s) => s.length < 1024).join('\n') | ||
| return writeFile(dest, data) | ||
| }).then(() => dest) |
There was a problem hiding this comment.
Suggestion: use async / await.
mcollina
force-pushed
the
fix-node-8-12-0
branch
from
bd949d4
to
7d895ad
Compare
|
PTAL |
|
Those lines cause the processor to fail, and we silence that error. I think this is just avoid future problems. |
|
@mcollina this doesn't seem to always fix the problem -- I'm still getting the error with lines > 1024 characters removed. Maybe something else besides long lines causes My workaround was to evaluate https://github.com/nodejs/node/blob/2ae98ce7cb95dee79e839afb2ee4c7d77d7670cd/lib/internal/v8_prof_processor.js in a new JS file, and the errors that were logged were all |
|
Can you upload an example to reproduce? Thanks!
Il giorno mer 17 ott 2018 alle 04:00 Zach Bjornson <notifications@github.com>
ha scritto:
… @mcollina <https://github.com/mcollina> this doesn't seem to always fix
the problem -- I'm still getting the error with lines > 1024 characters
removed. Maybe something else besides long lines causes printErr to be
invoked?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#172 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADL48cCIzKlM6difeCY9CTbgXgEhtQ7ks5ulo8qgaJpZM4WwD5Q>
.
|
|
Here's one: isolate-0x3aad0c0-v8.log |
No description provided.