Further round trip fixes (profiles) #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendellpiez
force-pushed
the
round-trip-fixes
branch
from
e1fe876
to
e60a420
Compare
david-waltermire
pushed a commit
that referenced
this pull request
Jun 11, 2019
Remove some JSON testing custom code and pip installs for Python in favor of AJV-CLI. Added XPath to the XML comparison code. Testing for XMLDIFF. Remove Unnecessary Python Libraries No longer using several external libraries Minor Updates FIxed git ignores Changed from -v check to something more compatible Updates to Testing Remove some JSON testing custom code and pip installs for Python in favor of AJV-CLI. Added XPath to the XML comparison code. Testing for XMLDIFF. Minor Updates FIxed git ignores Changed from -v check to something more compatible Bash Generalization Fixed the -v statements to use a more portable -z statement. Added Exit Code Logic to XML Round Trip Comparison Refactor XML Comparison Removes XMLDiff Adds exit code to the Python code, does error count tracking Test Content Converer Fix XML RoundTrip in Run All Tests Round Trip XML->JSON->XML Working for all NIST 800-53 checks (FedRAMP currently bombing) Color Output Printf messages are now color coded for improved readability in large log files Temp Directory Round trip files now written to the Temp directory, this directory added to build artifacts in CI/CD Rename Temporal Files Build files for roundtrip now carry their base naming conventions for troubleshooting Add Roundtrip Check to CI/CD Initial Attempt Fix CI/CD Bug Typo on base image Local JAR Trying to get it working end to end with local file Dynamic Paths Fix CI/CD bug finding Python/Saxon scripts PIP Installs Python Import Error Fix UTF Encoding Refactor Python Get etree.parse to work in CI/CD Shorten FileNames Build Artifacts Use the supplied build directory Troubleshoot Artifacts Dynamic JAR Dynamic JAR 2 Maven Install Adds Maven to the Circle CI image Maven Attempt #2 Class Path Refactor Refactor CI/CD Faster build time CI/CD Bug Fix Fix Path Error Copy Build Artifacts Copy Artifacts Attempt #2 Artifact Try #3 Artifact Attempt #4 Copy Step Artifacts #5 Fix Tab Artifact #6 Artifact #7 Artifact #8 Artifact #9 Initial JSON Roundtrip Remove Diff Updates to Testing Remove some JSON testing custom code and pip installs for Python in favor of AJV-CLI. Added XPath to the XML comparison code. Testing for XMLDIFF. Minor Updates FIxed git ignores Changed from -v check to something more compatible Updates to Testing Remove some JSON testing custom code and pip installs for Python in favor of AJV-CLI. Added XPath to the XML comparison code. Testing for XMLDIFF. Bash Generalization Fixed the -v statements to use a more portable -z statement. Added Exit Code Logic to XML Round Trip Comparison Refactor XML Comparison Removes XMLDiff Adds exit code to the Python code, does error count tracking Test Content Converer Fix XML RoundTrip in Run All Tests Round Trip XML->JSON->XML Working for all NIST 800-53 checks (FedRAMP currently bombing) Color Output Printf messages are now color coded for improved readability in large log files Temp Directory Round trip files now written to the Temp directory, this directory added to build artifacts in CI/CD Rename Temporal Files Build files for roundtrip now carry their base naming conventions for troubleshooting Add Roundtrip Check to CI/CD Initial Attempt Fix CI/CD Bug Typo on base image Local JAR Trying to get it working end to end with local file Dynamic Paths Fix CI/CD bug finding Python/Saxon scripts PIP Installs Python Import Error Fix UTF Encoding Refactor Python Get etree.parse to work in CI/CD Shorten FileNames Build Artifacts Use the supplied build directory Troubleshoot Artifacts Dynamic JAR Dynamic JAR 2 Maven Install Adds Maven to the Circle CI image Maven Attempt #2 Class Path Refactor CI/CD Bug Fix Fix Path Error Copy Build Artifacts Copy Artifacts Attempt #2 Artifact Try #3 Artifact Attempt #4 Copy Step Artifact #7 Artifact #8 Artifact #9 Initial JSON Roundtrip Remove Diff Merge with Master CI/CD Fix #2 CI/CD Fix #4 CI/CD Fix #5 CI/CD Fix #6
david-waltermire
pushed a commit
that referenced
this pull request
Jun 11, 2019
david-waltermire
pushed a commit
that referenced
this pull request
Jul 2, 2019
…-metaschema JSON Schema Design Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
This PR corrects a small error in the profile metaschema with big downstream effects, namely that it breaks the XML to JSON conversion. When an object can be addressed by (labelled with) a flag, its container in the JSON becomes a map not an array; this happens only if its references in the metaschema have
@addressvalues corresponding to its definition. The Metaschema Schematron has been modified to detect the error in future.All Submissions:
Changes to Core Features: