add auto mac discovery + many errors cleanups #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the amazing work done by @f1ren in #9, and strips down the HA add-on changes (I added more comprehensive addon support in my fork that we can discuss on merging in a different PR). In addition, I noticed so many errors and retires and I fixed them all - I have created a task queue that is in charge of stoping and starting scan when nesecary and keeping the connections alive for reuse.
You can check out my work by easily adding my HA addon according to the instructions here
@dauden1184 I know this is a big change, but I believe it is a blessed one and it improves performance by a great magnitude (at least for me). I would appreciate your comments (and @f1ren)