feat(ingest): add escape hatch methods to SqlParsingAggregator #9860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
5 tasks
treff7es
approved these changes
Feb 21, 2024
| query_fingerprint = get_query_fingerprint( | ||
| known_query_lineage.query_text, self.platform.platform_name | ||
| ) | ||
| # TODO format the query text? |
There was a problem hiding this comment.
I think formatting the query might be useful if we don't do it on the frontend side when we are showing the queries, but it should be optional.
There was a problem hiding this comment.
yeah I will do it in a future PR
| QueryMetadata( | ||
| query_id=query_fingerprint, | ||
| formatted_query_string=known_query_lineage.query_text, | ||
| session_id=_MISSING_SESSION_ID, |
There was a problem hiding this comment.
Is there a value if we can pass in session id to the know lineage as well?
There was a problem hiding this comment.
In some case I think we should be able to capture
There was a problem hiding this comment.
yup I'll add that in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist