fix(ui/token): token page failing to render #9827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } = entity; | ||
| const displayNameSearchResult = info?.displayName || editableProperties?.displayName || entity.username; |
There was a problem hiding this comment.
cool I know this is an improvement for sure. can we just call entityRegistry.getDisplayName(entity.type, entity) here though?
There was a problem hiding this comment.
Sure, we can simplify it by using entityRegistry.getDisplayName(entity.type, entity). Updated as per your suggestion.
chriscollins3456
approved these changes
Feb 14, 2024
| info: { displayName }, | ||
| } = entity; | ||
| const { editableProperties } = entity; | ||
| const displayNameSearchResult = entityRegistry.getDisplayName(EntityType.CorpUser, entity); |
There was a problem hiding this comment.
do we always know this will be a corpuser or could it be a corpGroup? I would just pass in entity.type instead of hardcoding EntityType.CorpUser
There was a problem hiding this comment.
Yes we always showing corp users data in dropdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist