fix(ingest/profiling): ignore limit/offset when counting table row count in profiling #9635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
asikowitz
reviewed
Jan 17, 2024
Comment on lines
+422
to
+429
| if (self.config.limit or self.config.offset) and not self.custom_sql: | ||
| # We don't want limit and offset to get applied to the row count | ||
| # This is kinda hacky way to do it, but every other way would require major refactoring | ||
| dataset_profile.rowCount = self.dataset.get_row_count( | ||
| self.dataset_name.split(".")[-1] | ||
| ) | ||
| else: | ||
| dataset_profile.rowCount = self.dataset.get_row_count() |
There was a problem hiding this comment.
Can you add these two cases to the existing if / else block? Also, how does this work...? Can you elaborate in the comment because I don't get it lol
hsheth2
approved these changes
Feb 12, 2024
hsheth2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist