-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gms/search): Adding support for DOUBLE Searchable type #9369
Merged
david-leifker
merged 12 commits into
datahub-project:master
from
siladitya2:add-double-searchable-type
Dec 6, 2023
Merged
feat(gms/search): Adding support for DOUBLE Searchable type #9369
david-leifker
merged 12 commits into
datahub-project:master
from
siladitya2:add-double-searchable-type
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto add-double-searchable-type
…tahub into add-double-searchable-type
…etype field mapping
david-leifker
approved these changes
Dec 6, 2023
LGTM! Thanks! |
Salman-Apptware
pushed a commit
to Salman-Apptware/datahub
that referenced
this pull request
Dec 15, 2023
…project#9369) Co-authored-by: si-chakraborty <si.chakraborty@adevinta.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Adding support for DOUBLE Searchable type.
We are facing one issue without it, we are unable to sort numeric field values(
double
) of an aspect correctly with the search API query(searchAcrossEntities
) as there is no option to map the aspect’s field type withnumeric:double
on Elastic search index(datasetindex_
).