Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(glossary): add toggle sidebar button and functionality to Busine… #9222

Conversation

olgadimova
Copy link
Contributor

…ss Glossary page

This PR adds collapse/expand sidebar button to 'Business Glossary' page similar to the one on 'Search' Page. Collapse/expand sidebar functionality makes working with Glossary easier as there is more space available for main glossary block and search is not always needed. Also, it is not possible to hide sidebar fully with existing resize sidebar functionality.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

toggle-glossary-1
toggle-glossary-2

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 10, 2023
@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Nov 13, 2023
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@chriscollins3456 chriscollins3456 merged commit 3096aa6 into datahub-project:master Dec 7, 2023
36 of 37 checks passed
Salman-Apptware pushed a commit to Salman-Apptware/datahub that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community poc-marathon-dec-2023 product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants