Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql-parser): convert platform instance to lowercase when building table urns #9181

Merged
merged 4 commits into from
Nov 16, 2023
Merged

fix(sql-parser): convert platform instance to lowercase when building table urns #9181

merged 4 commits into from
Nov 16, 2023

Conversation

Starkie
Copy link
Contributor

@Starkie Starkie commented Nov 6, 2023 •
edited
Loading

A naive approach for fixing #9172. I simply transform the platform instance to lower case when required.

Checklist

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 6, 2023
@maggiehays maggiehays added community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX labels Nov 13, 2023
hsheth2
hsheth2 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2 hsheth2 changed the title fix(sql-parsing): convert platform instance to lowercase when building table urns fix(sql-parser): convert platform instance to lowercase when building table urns Nov 16, 2023
@hsheth2 hsheth2 merged commit d0fa5de into datahub-project:master Nov 16, 2023
51 checks passed
@Starkie Starkie deleted the fix/9172/search-assets-lowercase-platform-instance branch November 17, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@asikowitz asikowitz Awaiting requested review from asikowitz

Assignees

@hsheth2 hsheth2

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mssql Ingestion - View lineage not generated when using Platform Instance with uppercase letters
3 participants
@Starkie @hsheth2 @maggiehays