Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBS-191 | Viewing domains page should not require Manage Domains priv… #9156

Merged
merged 2 commits into from
Nov 4, 2023

Conversation

sumitappt
Copy link
Collaborator

…ilege

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 1, 2023
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this looks incorrect.

The user should be able to view domains always, even if they cannot create domains.

I should have specified further.

@sumitappt
Copy link
Collaborator Author

Actually this looks incorrect.

The user should be able to view domains always, even if they cannot create domains.

I should have specified further.

Got it. We should remove the privilege checks for creating and managing domains since they should always be visible.

@jjoyce0510 jjoyce0510 enabled auto-merge (squash) November 4, 2023 19:07
@jjoyce0510 jjoyce0510 merged commit 7cfe3c7 into datahub-project:master Nov 4, 2023
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants