Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ingest/hive): Update thrift pin #8964

Merged
merged 5 commits into from
Nov 16, 2023
Merged

build(ingest/hive): Update thrift pin #8964

merged 5 commits into from
Nov 16, 2023

Conversation

asikowitz
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@asikowitz asikowitz requested a review from hsheth2 October 5, 2023 19:08
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 5, 2023
hsheth2
hsheth2 approved these changes Oct 5, 2023
View reviewed changes
metadata-ingestion/setup.py Outdated Show resolved Hide resolved
@hsheth2
Copy link
Collaborator

hsheth2 commented Oct 5, 2023

@asikowitz actually looks like they haven't released thrift 0.17.0 yet

https://pypi.org/project/thrift/

@asikowitz
Copy link
Collaborator Author

Hm.... on github they're already on 0.19.0 and 0.17.0 came out over a year ago. Kinda unreasonable

@asikowitz asikowitz marked this pull request as draft October 5, 2023 19:58
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
@asikowitz asikowitz marked this pull request as ready for review November 16, 2023 17:51
hsheth2
hsheth2 approved these changes Nov 16, 2023
View reviewed changes
metadata-ingestion/setup.py Show resolved Hide resolved
@asikowitz @hsheth2
Update metadata-ingestion/setup.py
5626a54 
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
@asikowitz
Copy link
Collaborator Author

Tests should be fixed by #9254

@asikowitz asikowitz merged commit b778def into datahub-project:master Nov 16, 2023
48 of 51 checks passed
@asikowitz asikowitz deleted the bump-thrift-pin branch November 16, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asikowitz @hsheth2 @maggiehays