-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revamp features page #8839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor style things, but overall looking good
one thing I want to talk about: people like screenshots. while I agree that this page isn't the right place for screenshots, what do you think is the right place for them?
docs-website/src/pages/docs/_components/QuickstartCards/index.jsx
Outdated
Show resolved
Hide resolved
@hsheth2 thx for the feedback! made some changes, let me know your thoughts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly looking good, nits on two small details
docs-website/src/pages/docs/_components/FeatureCardSection/featurecardsection.module.scss
Show resolved
Hide resolved
{ | ||
title: "Quickstart with DataHub", | ||
icon: "datahub-logo-color-mark", | ||
to: "docs/quickstart", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like these links doesn't respect the currently active version
there might be some weird docusaurus magic required here to prefix the links (https://docusaurus.io/docs/docusaurus-core#useDocusaurusContext). alternatively, it might work if you make them relative links e.g ./quickstart
or something
Checklist