Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): add ability to provide a startingOffset for RestoreIndices #8539

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

ukayani
Copy link
Contributor

@ukayani ukayani commented Aug 1, 2023

Running the RestoreIndices on a slow DB or a very large table can take a long time -- this change is intended to allow resuming at a particular startingOffset.

  • Modified the RestoreIndices job to accept an optional startingOffset param which gets propagated to the RestoreIndicesArgs start property

Checklist

  • [ x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • [x ] Links to related issues (if applicable)
  • [x ] Tests for the changes have been added/updated (if applicable)
  • [ x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • [ x] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@david-leifker david-leifker added the devops PR or Issue related to DataHub backend & deployment label Aug 2, 2023
@david-leifker david-leifker merged commit 0f3819b into datahub-project:master Sep 11, 2023
31 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants