Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert signup page #10282

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix: revert signup page #10282

merged 1 commit into from
Apr 12, 2024

Conversation

yoonhyejin
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

shirshanka
shirshanka approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

swaroopjagadish
swaroopjagadish approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@swaroopjagadish swaroopjagadish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yoonhyejin yoonhyejin merged commit 9193d18 into master Apr 12, 2024
33 of 34 checks passed
@yoonhyejin yoonhyejin deleted the docs/revert-signup branch April 12, 2024 23:09
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@yoonhyejin @sleeperdeep
fix: revert signup page (datahub-project#10282)
30aba9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@swaroopjagadish swaroopjagadish swaroopjagadish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoonhyejin @shirshanka @swaroopjagadish