Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert docker helper changes #10172

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Revert docker helper changes #10172

merged 1 commit into from
Mar 31, 2024

Conversation

david-leifker
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Mar 29, 2024
shirshanka
shirshanka approved these changes Mar 31, 2024
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-leifker david-leifker merged commit 7f7d713 into master Mar 31, 2024
39 of 41 checks passed
@david-leifker david-leifker deleted the pr-prefix-sha-tags branch March 31, 2024 02:55
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@david-leifker @sleeperdeep
Revert docker helper changes (datahub-project#10172)
85f0ef8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@RyanHolstien RyanHolstien Awaiting requested review from RyanHolstien

@darnaut darnaut Awaiting requested review from darnaut

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @shirshanka