Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<fix>[oracle ingestion]: get database name when using service #10158

Merged
merged 5 commits into from
Apr 1, 2024
Merged

<fix>[oracle ingestion]: get database name when using service #10158

merged 5 commits into from
Apr 1, 2024

Conversation

Nelvin73
Copy link
Contributor

@Nelvin73 Nelvin73 commented Mar 28, 2024 •
edited
Loading

This fixes the problem, that oracle database name is not retrieved, when a service is used for connection.
In that case, it will try to retrieve the database name from current connection using a query.

Related Bugs: #8148, #9931

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

<fix>[oracle ingestion]: get database name when using service
3c4c4be 
This fixes the problem, that oracle database name is not retrieved, when a service is used for connection.
Bugs datahub-project#8148, datahub-project#9931
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 28, 2024
asikowitz
asikowitz approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Seems reasonable to me and safe to add

@asikowitz asikowitz merged commit 14bbc0b into datahub-project:master Apr 1, 2024
56 of 57 checks passed
@Nelvin73 Nelvin73 deleted the feat-fetch-oracle-db-name branch April 2, 2024 10:49
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@Nelvin73 @sleeperdeep
<fix>[oracle ingestion]: get database name when using service (datahu…
136a6ed 
…b-project#10158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asikowitz asikowitz asikowitz approved these changes

Assignees

@asikowitz asikowitz

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nelvin73 @asikowitz